Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #351 to citadel: fix dartsim inertia matrix rotation #568

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Nov 9, 2023

🦟 Bug fix

Backport #351 to citadel, better late than never (#351 (comment))

Summary

Original commit message:

dartsim: fix handling inertia matrix pose rotation (#351)

When loading a model from SDF, the moment of inertia matrix is currently applying any rotations in the //inertial/pose two times, since the rotations are applied explicitly, but they are already applied in math::Inertial::Moi.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Rebase-and-Merge.

When loading a model from SDF, the moment of inertia matrix
is currently applying any rotations in the //inertial/pose
two times, since the rotations are applied explicitly, but
they are already applied in math::Inertial::Moi.

Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
@scpeters scpeters requested review from azeey and mxgrey as code owners November 9, 2023 13:13
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Nov 9, 2023
@scpeters
Copy link
Member Author

scpeters commented Nov 9, 2023

FYI @j-rivero the ign_physics-ci-pr_any-homebrew-amd64 build is using the wrong formula name: ign-physics2 instead of ignition-physics2

+ brew install ign-physics2 --only-dependencies
Warning: No available formula with the name "ign-physics2". Did you mean gz-physics8, gz-physics7 or gz-physics6?
==> Searching for similarly named formulae and casks...
==> Formulae
osrf/simulation/gz-physics8
osrf/simulation/gz-physics7
osrf/simulation/gz-physics6

To install osrf/simulation/gz-physics8, run:
  brew install osrf/simulation/gz-physics8
Build step 'Execute shell' marked build as failure

@j-rivero
Copy link
Contributor

@osrf-jenkins run tests

@scpeters
Copy link
Member Author

I could add ign-* aliases for citadel and fortress formulae if that's simpler than fixing the release-tools logic

@j-rivero
Copy link
Contributor

I could add ign-* aliases for citadel and fortress formulae if that's simpler than fixing the release-tools logic

Lets try to fix the problem in the right way gazebo-tooling/release-tools#1068

@j-rivero
Copy link
Contributor

@osrf-jenkins run tests please

@scpeters
Copy link
Member Author

thanks @j-rivero! the homebrew build is working now

@scpeters scpeters merged commit eb291a9 into ign-physics2 Nov 13, 2023
7 checks passed
@scpeters scpeters deleted the scpeters/backport_dart_inertia_fix branch November 13, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants