[Citadel] [TPE] Add function to get an Entity's bounding box #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-physics2 #59 +/- ##
================================================
+ Coverage 81.53% 81.81% +0.27%
================================================
Files 103 104 +1
Lines 3434 3492 +58
================================================
+ Hits 2800 2857 +57
- Misses 634 635 +1
Continue to review full report at Codecov.
|
claireyywang
reviewed
Jun 2, 2020
| namespace tpelib { | ||
|
|
||
| ////////////////////////////////////////////////// | ||
| math::AxisAlignedBox transformAxisAlignedBox( |
There was a problem hiding this comment.
Could we add more documentation on the math behind this function? I find it a bit hard to understand by just reading the code.
There was a problem hiding this comment.
added more doc and testing linker fix in 558cbb7
Signed-off-by: Ian Chen <[email protected]>
claireyywang
approved these changes
Jun 2, 2020
Signed-off-by: Ian Chen <[email protected]>
|
all checks passed, merging! actually.. need to merge with with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helper function that returns an entity's bounding box by recursively merging it's children's bounding boxes.