Add plugin name accessor

[nlamprian]

Closes #5

Signed-off-by: Nick Lamprianidis [email protected]

[mxgrey]

Thanks for the contribution! I just have one remark, left as an inline comment.

[chapulina]

Thanks for the PR! Mind adding some tests to check names here:

https://github.com/ignitionrobotics/ign-plugin/blob/main/test/integration/plugin.cc

And maybe also here:

https://github.com/ignitionrobotics/ign-plugin/blob/main/test/integration/templated_plugins.cc

[nlamprian]

Good thing that you asked for the tests. I removed the const reference and added a check for the pointer.

Btw last time, I had a hard time following what the classes do. These tests are a nice overview.

[chapulina]

Thank you for iterating and for the comprehensive tests. I think this is good to go once the doxygen is updated.

[scpeters]

this is targeting main, so we can backport it to ign-plugin1 after it is merged

[nlamprian]

this is targeting main, so we can backport it to ign-plugin1 after it is merged

Care to elaborate? I changed a header file, shouldn't this prevent it from being merged into ign-plugin1?

[scpeters]

this is targeting main, so we can backport it to ign-plugin1 after it is merged

Care to elaborate? I changed a header file, shouldn't this prevent it from being merged into ign-plugin1?

adding a non-virtual function to a class doesn't break API or ABI, so it's fine to do for ign-plugin1. Per semver.org, we should bump the minor version when "adding functionality in a backwards compatible manner", but it doesn't break anything

[nlamprian]

In that case, I can simply rebase here. It doesn't seem there are any conflicts. Let me know.

[scpeters]

In that case, I can simply rebase here. It doesn't seem there are any conflicts. Let me know.

sounds good. I just changed the target of this PR to ign-plugin1; please go ahead and rebase

[scpeters]

thanks for the contribution!