-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the Ignition custom CLI formatter #69
Conversation
Signed-off-by: Michael Carroll <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI isn't happy. Do you need to update a test?
It needed an upstream release, but that should have gone out already with ign-utils1 1.4.0 |
Signed-off-by: Louise Poubel <[email protected]>
Yeah it looks like the tests need to be updated:
|
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 99.35% 99.35% -0.01%
==========================================
Files 17 17
Lines 618 617 -1
==========================================
- Hits 614 613 -1
Misses 4 4
Continue to review full report at Codecov.
|
Requires gazebosim/gz-utils#42
New output:
Signed-off-by: Michael Carroll [email protected]