Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Ignition custom CLI formatter #69

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

Requires gazebosim/gz-utils#42

New output:

Print information about plugins.

Usage: ./ignition-plugin2/bin/ign-plugin [OPTIONS]

Options:
  -h [--help]                 Print this help message and exit
                              
  --version                   Print version number
                              
  -v [--verbose]              Print verbose info.
                              
  -p [--plugin] TEXT          Path to a plugin.
                              Required by: --info
                              
  -i [--info]                 Get info about a plugin.
                              Requires: --plugin
                              

Signed-off-by: Michael Carroll [email protected]

@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Mar 11, 2022
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI isn't happy. Do you need to update a test?

@mjcarroll
Copy link
Contributor Author

CI isn't happy. Do you need to update a test?

It needed an upstream release, but that should have gone out already with ign-utils1 1.4.0

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor

Yeah it looks like the tests need to be updated:

  Expected: (std::string::npos) != (output.find("-i,--info                   Get info about a plugin.")), actual: 18446744073709551615 vs 18446744073709551615
  Print information about plugins.
  
  Usage: /github/workspace/build/bin/ign-plugin [OPTIONS]
  
  Options:
    -h [--help]                 Print this help message and exit
                                
    --version                   Print version number
                                
    -v [--verbose]              Print verbose info.
                                
    -p [--plugin] TEXT          Path to a plugin.
                                Required by: --info
                                
    -i [--info]                 Get info about a plugin.
                                Requires: --plugin
                                
  
  
  /github/workspace/loader/src/ign_TEST.cc:74: Failure
  Expected: (std::string::npos) != (output.find("-p,--plugin TEXT Needs: --info")), actual: 18446744073709551615 vs 18446744073709551615
  Print information about plugins.
  
  Usage: /github/workspace/build/bin/ign-plugin [OPTIONS]
  
  Options:
    -h [--help]                 Print this help message and exit
                                
    --version                   Print version number
                                
    -v [--verbose]              Print verbose info.
                                
    -p [--plugin] TEXT          Path to a plugin.
                                Required by: --info
                                
    -i [--info]                 Get info about a plugin.
                                Requires: --plugin

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Apr 1, 2022
@chapulina chapulina added the 🌱 garden Ignition Garden label May 26, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #69 (4bfefee) into main (3262c92) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   99.35%   99.35%   -0.01%     
==========================================
  Files          17       17              
  Lines         618      617       -1     
==========================================
- Hits          614      613       -1     
  Misses          4        4              
Impacted Files Coverage Δ
loader/src/cmd/plugin_main.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3262c92...4bfefee. Read the comment docs.

@chapulina chapulina merged commit cc8233f into main Jul 6, 2022
@chapulina chapulina deleted the custom_cli_formatter branch July 6, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants