Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Header Migration : ign-plugin #79

Merged
merged 4 commits into from
May 3, 2022
Merged

ign -> gz Header Migration : ign-plugin #79

merged 4 commits into from
May 3, 2022

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 28, 2022
@methylDragon methylDragon mentioned this pull request Apr 28, 2022
Closed
@methylDragon methylDragon marked this pull request as draft April 28, 2022 23:55
@methylDragon methylDragon force-pushed the header_migration branch 2 times, most recently from 33433c7 to 0c81b19 Compare April 29, 2022 01:52
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 2, 2022
scpeters
scpeters requested changes May 3, 2022
View reviewed changes
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing redirection headers:

  • core/include/ignition/plugin.hh
  • core/include/ignition/plugin/Export.hh
  • core/include/ignition/plugin/detail/Export.hh
  • loader/include/ignition/plugin/loader/Export.hh
  • loader/include/ignition/plugin/loader/detail/Export.hh

@methylDragon methylDragon marked this pull request as ready for review May 3, 2022 08:30
@methylDragon
Copy link
Contributor Author

missing redirection headers:

  • core/include/ignition/plugin.hh
  • core/include/ignition/plugin/Export.hh
  • core/include/ignition/plugin/detail/Export.hh
  • loader/include/ignition/plugin/loader/Export.hh
  • loader/include/ignition/plugin/loader/detail/Export.hh

They're all in now! 🚀

@methylDragon methylDragon force-pushed the header_migration branch 2 times, most recently from ba87a78 to 62ea8e4 Compare May 3, 2022 08:45
@methylDragon
Copy link
Contributor Author

methylDragon commented May 3, 2022 •
edited
Loading

Windows red CI seems to come from a CMake variable not being used (CMAKE_TOOLCHAIN_FILE)
https://build.osrfoundation.org/job/ign_plugin-pr-win/60/cmake/

I don't think this is related.

EDIT: It was related. Fixed.

@methylDragon
Migrate CMake files
3db49e5 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon merged commit 35fc976 into main May 3, 2022
@methylDragon methylDragon deleted the header_migration branch May 3, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methylDragon @scpeters @chapulina