Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert all and only enabled (and not skipped) engines in default value of RENDER_ENGINE_VALUES #455

Open
traversaro opened this issue Oct 7, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@traversaro
Copy link
Contributor

traversaro commented Oct 7, 2021

Desired behavior

I would like that after a configuration of ign-rendering on a given system, ctest would actually test just and only the enabled engines. At the moment this is not the case, as the list of tested engines is hardcoded in https://github.com/ignitionrobotics/ign-rendering/blob/50e1e5fa936176a570b6b4cccbbe081334af6057/test/test_config.h.in#L14

Alternatives considered

Leave the situation like this, where the default value of RENDER_ENGINE_VALUES reflect the official OpenRobotics CI configuration. In that case however it would be great if the test could explicitly fail on missing engine, so that it is clear that the "user" (tipically someone packaging the library) needs to set the RENDER_ENGINE_VALUES env variable value.

Implementation suggestion

If the feature is welcome, I can look in the suggestion.

Additional context

See conda-forge/libignition-rendering4-feedstock#19 (comment) for the context in which this issue was detected.

@traversaro traversaro added the enhancement New feature or request label Oct 7, 2021
@iche033
Copy link
Contributor

iche033 commented Nov 29, 2021

it would be great if the test could explicitly fail on missing engine, so that it is clear that the "user" (tipically someone packaging the library) needs to set the RENDER_ENGINE_VALUES env variable value.

ok yeah that sounds good to me.

ctest would actually test just and only the enabled engines

One comment: we currently don't have a way to run ogre and ogre2 tests one after another because of symbol collision. So one thing to keep in mind is that these two engines can not be enabled at the same time.

@chapulina chapulina added the help wanted Extra attention is needed label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants