Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests for available render engines #683

Closed
iche033 opened this issue Jul 21, 2022 · 2 comments
Closed

Run tests for available render engines #683

iche033 opened this issue Jul 21, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@iche033
Copy link
Contributor

iche033 commented Jul 21, 2022 •
edited
Loading

Currently we only run tests for engines specified in the RENDER_ENGINE_VALUES variable. If an engine is not available, it just skips the test. Additionally, ogre and ogre2 tests can not be run one after another due to possible symbol collision. It would be nice to have a way to run tests for all render engine that are available.

Desired behavior

Run tests for all render engine that are available.

Alternatives considered

Run test one after another but ogre and ogre2 tests can not be run in the same process

Implementation suggestion

One suggestion is to generate separate test executables for each render engine, e.g. UNIT_ogre_Scene_TEST and UNIT_ogre2_Scene_TEST

Additional context

Related comment: #670 (comment)
Related issue: #455
@iche033 iche033 added the enhancement New feature or request label Jul 21, 2022
@iche033 iche033 mentioned this issue Jul 21, 2022
Merged
8 tasks
@mjcarroll
Copy link
Contributor

One suggestion is to generate separate test executables for each render engine, e.g. UNIT_ogre_Scene_TEST and UNIT_ogre2_Scene_TEST

I like this idea better than the current mechanism +1

@mjcarroll mjcarroll mentioned this issue Jul 26, 2022
Merged
9 tasks
@chapulina chapulina added the help wanted Extra attention is needed label Jul 27, 2022
@iche033
Copy link
Contributor Author

iche033 commented Oct 6, 2023

#685 and #694

@iche033 iche033 closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjcarroll @iche033 @chapulina