Frustum Visual ABI compatibility changes #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Signed-off-by: Ian Chen <[email protected]>
iche033
force-pushed
the
backport_frustum_visual_abi
branch
from
f227294 to
48cf8a1
Compare
|
abi checker build passed with 100% compatibility: https://build.osrfoundation.org/job/gz_rendering-abichecker-any_to_any-ubuntu-noble-amd64/66/API_5fABI_20report/ |
ahcorde
approved these changes
Jan 17, 2025
iche033
added a commit
that referenced
this pull request
Jan 27, 2025
Signed-off-by: Ian Chen <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Implement ABI compatibility changes for the Frustum Visual feature (#1095) so that it can be backported to gz-rendering9. The approach is similar to #845 which uses the
SceneExtclass for creating the visual frustum to prevent overriding virtual functions (which breaks ABI). The official functions for creatingFrustumVisualclasses are commented out (instead of being removed) to keep the diff withmainminimal.I also added a unit test for the FrustumVisual class.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.