Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to tutorials #143

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Updates to tutorials #143

merged 1 commit into from
Sep 25, 2020

Conversation

chapulina
Copy link
Contributor

  • Instruct user to clone this repository: users landing in https://ignitionrobotics.org/api/rendering/4.0/tutorials.html don't know where to start from otherwise
  • Split command from command results, so it's clearer to the user what they need to do
  • Fix the custom shaders tutorial - it was telling the user to compile the camera tracking

I updated many tutorials, but I only walked through these ones:

  • custom shaders
  • particles
  • text geometry
  • render pass

There may be more things to fix on the other ones.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the documentation Improvements or additions to documentation label Sep 24, 2020
@chapulina chapulina requested a review from iche033 as a code owner September 24, 2020 21:58
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 24, 2020
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   52.07%   52.07%           
=======================================
  Files         143      143           
  Lines       13105    13105           
=======================================
  Hits         6824     6824           
  Misses       6281     6281           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f242c9...24e8c33. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@chapulina chapulina merged commit 1ef0388 into master Sep 25, 2020
@chapulina chapulina deleted the chapulina/4/tutorials branch September 25, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants