Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update particles tutorial image #159

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Update particles tutorial image #159

merged 1 commit into from
Oct 7, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 7, 2020

Changed the image to the fire breathing duck gif from pull request #153

Signed-off-by: Ian Chen [email protected]

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from JShep1 October 7, 2020 03:20
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #159 into ign-rendering4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering4     #159   +/-   ##
===============================================
  Coverage           52.07%   52.07%           
===============================================
  Files                 143      143           
  Lines               13105    13105           
===============================================
  Hits                 6824     6824           
  Misses               6281     6281           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e34fa79...1bf2a99. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#gzgif ❗

@chapulina chapulina merged commit 6cedee7 into ign-rendering4 Oct 7, 2020
@chapulina chapulina deleted the particles_gif branch October 7, 2020 16:37
@iche033 iche033 restored the particles_gif branch March 30, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants