-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rendering Plugin Tutorial #161
Merged
iche033
merged 16 commits into
ign-rendering3
from
jshep1/add_rendering_plugin_tutorial
Oct 13, 2020
Merged
Add Rendering Plugin Tutorial #161
iche033
merged 16 commits into
ign-rendering3
from
jshep1/add_rendering_plugin_tutorial
Oct 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Add null checks and docs Signed-off-by: Ian Chen <[email protected]> Co-authored-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
…_binary_name_support Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
…custom_plugin_example
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
4 tasks
chapulina
added
documentation
Improvements or additions to documentation
🏰 citadel
Ignition Citadel
labels
Oct 8, 2020
iche033
reviewed
Oct 9, 2020
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
iche033
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made one minor tweak to heading. 128638f
This looks good to me.
Base automatically changed from
jshep1/add_custom_plugin_example
to
ign-rendering3
October 13, 2020 20:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a more high-leveled tutorial of how to create a custom rendering engine plugin. Should we go into more detail as the physics equivalent does?
Signed-off-by: John Shepherd [email protected]