Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rendering Plugin Tutorial #161

Merged
merged 16 commits into from
Oct 13, 2020

Conversation

JShep1
Copy link

@JShep1 JShep1 commented Oct 8, 2020

Adding a more high-leveled tutorial of how to create a custom rendering engine plugin. Should we go into more detail as the physics equivalent does?

Signed-off-by: John Shepherd [email protected]

John Shepherd and others added 13 commits September 23, 2020 14:29
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Add null checks and docs

Signed-off-by: Ian Chen <[email protected]>

Co-authored-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
Signed-off-by: John Shepherd <[email protected]>
@chapulina chapulina added documentation Improvements or additions to documentation 🏰 citadel Ignition Citadel labels Oct 8, 2020
tutorials/03_rendering_plugins.md Outdated Show resolved Hide resolved
tutorials/03_rendering_plugins.md Outdated Show resolved Hide resolved
tutorials/03_rendering_plugins.md Outdated Show resolved Hide resolved
tutorials/03_rendering_plugins.md Outdated Show resolved Hide resolved
tutorials/03_rendering_plugins.md Outdated Show resolved Hide resolved
tutorials/03_rendering_plugins.md Outdated Show resolved Hide resolved
Signed-off-by: John Shepherd <[email protected]>
@JShep1 JShep1 requested a review from iche033 October 12, 2020 23:14
Signed-off-by: Ian Chen <[email protected]>
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made one minor tweak to heading. 128638f

This looks good to me.

Base automatically changed from jshep1/add_custom_plugin_example to ign-rendering3 October 13, 2020 20:57
@iche033 iche033 merged commit 816177b into ign-rendering3 Oct 13, 2020
@iche033 iche033 deleted the jshep1/add_rendering_plugin_tutorial branch October 13, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants