Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash due to NaN pose values #169

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Fix crash due to NaN pose values #169

merged 3 commits into from
Oct 27, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 27, 2020

ogre 1 and 2 crashes if given nan pose values. This PR catches nan and inf values before passing them to the underlying render engine.

Signed-off-by: Ian Chen [email protected]

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #169 into ign-rendering3 will decrease coverage by 0.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering3     #169      +/-   ##
==================================================
- Coverage           50.45%   50.45%   -0.01%     
==================================================
  Files                 129      129              
  Lines               11750    11756       +6     
==================================================
+ Hits                 5929     5932       +3     
- Misses               5821     5824       +3     
Impacted Files Coverage Δ
include/ignition/rendering/base/BaseNode.hh 81.31% <25.00%> (-1.37%) ⬇️
include/ignition/rendering/base/BaseVisual.hh 91.66% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf3bbb0...026b4f1. Read the comment docs.

@iche033 iche033 merged commit 1233f20 into ign-rendering3 Oct 27, 2020
@iche033 iche033 deleted the node_nan_pose branch October 27, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants