Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix converting Pbs to Unlit material conversion #230

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 3, 2021

Thermal camera uses unlit material for background objects. When visualizing thermal camera output in a more complex environment, I noticed that the textures are not correct copied over from Pbs to Unlit datablock. The changes here make sure we set the correct texture file to the unlit material.

Signed-off-by: Ian Chen [email protected]

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from adlarkin February 3, 2021 21:53
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Feb 3, 2021
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to make an ign-rendering patch release for this to be used in SubT (4.3.1, right?).

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #230 (9fc1365) into ign-rendering4 (cbe4fb7) will decrease coverage by 0.02%.
The diff coverage is 37.50%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering4     #230      +/-   ##
==================================================
- Coverage           52.77%   52.75%   -0.03%     
==================================================
  Files                 143      143              
  Lines               13492    13493       +1     
==================================================
- Hits                 7121     7118       -3     
- Misses               6371     6375       +4     
Impacted Files Coverage Δ
ogre2/src/Ogre2ThermalCamera.cc 89.87% <ø> (ø)
ogre2/src/Ogre2Material.cc 93.28% <37.50%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe4fb7...9fc1365. Read the comment docs.

@iche033
Copy link
Contributor Author

iche033 commented Feb 3, 2021

We'll need to make an ign-rendering patch release for this to be used in SubT (4.3.1, right?).

yeah 4.3.1

@adlarkin adlarkin merged commit a7c4712 into ign-rendering4 Feb 3, 2021
@adlarkin adlarkin deleted the fix_unlit_ogre2 branch February 3, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants