-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 8 bit thermal camera image format #235
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering4 #235 +/- ##
==================================================
+ Coverage 52.75% 52.87% +0.12%
==================================================
Files 143 143
Lines 13493 13522 +29
==================================================
+ Hits 7118 7150 +32
+ Misses 6375 6372 -3
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments have been addressed, and all checks have passed - LGTM!
Summary
The existing thermal camera implementation produces image output in 16 bit format and that's being hard coded in various places including the shaders. This PR makes the implementation slightly more generic to support generating 8 bit data.
There are a few workarounds that had to be done so that this change does not break ABI. For example, the new thermal image event's function callback is hard coded to
uint16_t
and that can not be changed so unfortunately I had to workaround this by packing 8 bit data into 16 bit array.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge