-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply particle scattering effect to lidars #252
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## depth_particles #252 +/- ##
==================================================
Coverage ? 54.02%
==================================================
Files ? 143
Lines ? 13917
Branches ? 0
==================================================
Hits ? 7518
Misses ? 6399
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned before, my understanding of what's going on here isn't perfect, so if someone else wants to take a look as well, go for it, but this looks good to me.
depends on #251
Summary
Lidars detect particles as large blocky squares due to the way particles are rendered in ogre (2d sprites / billboard). This PR applies scattering effect in a similar way as it's done for the depth camera in pull request #251. Whenever a ray in the lidar intersects with a particle, there is a chance that it'll miss or become scattered (by adding Gaussian noise).
Test it
Visualize Lidar
/lidar
topicChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge