Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master branch updates #268

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Master branch updates #268

merged 2 commits into from
Mar 9, 2021

Conversation

chapulina
Copy link
Contributor

Part of gazebo-tooling/release-tools#416

Summary

Update all usage of master

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

chapulina added 2 commits March 8, 2021 15:26
@chapulina
Master branch updates
4a5d647 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Remove Xenial
f7a5b59 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from iche033 as a code owner March 8, 2021 23:27
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021 •
edited
Loading

Codecov Report

Merging #268 (f7a5b59) into ign-rendering3 (fd17602) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering3     #268   +/-   ##
===============================================
  Coverage           50.59%   50.59%           
===============================================
  Files                 129      129           
  Lines               11887    11887           
===============================================
  Hits                 6014     6014           
  Misses               5873     5873

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd17602...f7a5b59. Read the comment docs.

@chapulina chapulina enabled auto-merge (squash) March 9, 2021 18:12
@chapulina chapulina merged commit 93539bd into ign-rendering3 Mar 9, 2021
@chapulina chapulina deleted the chapulina/bye_master branch March 9, 2021 19:25
chapulina added a commit that referenced this pull request Mar 17, 2021
@chapulina @iche033
3 ➡️ 4 (#270)
2c4910d 
* Master branch updates (#268)

Signed-off-by: Louise Poubel <[email protected]>

* Fix DepthGaussianNoise test (#271)

Signed-off-by: Ian Chen <[email protected]>

Co-authored-by: Ian Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @iche033