Added command line argument for examples to pick version of Ogre #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
approved these changes
Mar 23, 2021
ahcorde
requested changes
Mar 23, 2021
There was a problem hiding this comment.
Do you mind to sign the commit ? https://github.com/ignitionrobotics/ign-rendering/pull/277/checks?check_run_id=2178517512
|
Sorry about, I believe I just signed the commit. I have also configured my GPG key so I think my future commits should contain my signature now. |
ahcorde
approved these changes
Mar 23, 2021
|
looks good to me. Just waiting for CI to finish |
Signed-off-by: WilliamLewww <[email protected]>
iche033
approved these changes
Mar 31, 2021
iche033
pushed a commit
that referenced
this pull request
May 15, 2021
* Added example for custom shaders with different uniform types Signed-off-by: William Lew <[email protected]> * Added buffer shader parameter Signed-off-by: William Lew <[email protected]> * Added ogre uniform buffer update Signed-off-by: William Lew <[email protected]> * Fixed uninitialized variables Signed-off-by: William Lew <[email protected]> * Added matrix uniform update Signed-off-by: William Lew <[email protected]> * Fixed shader paths Signed-off-by: William Lew <[email protected]> * Added command line argument to pick version of Ogre (#277) Signed-off-by: WilliamLewww <[email protected]> Signed-off-by: William Lew <[email protected]> * Fixed C-style cast and formatting issues Signed-off-by: William Lew <[email protected]> * Changed raw pointer buffer to shared pointer buffer Signed-off-by: William Lew <[email protected]> * Specified uniform buffer to be a word buffer Signed-off-by: William Lew <[email protected]> * Fixed codecheck errors Signed-off-by: William Lew <[email protected]> * Added documentation for word buffer Signed-off-by: William Lew <[email protected]> * Added tests for word buffer shader parameter Signed-off-by: William Lew <[email protected]> * Fixed updating int uniform buffer Signed-off-by: William Lew <[email protected]> * Added tests for int and float uniform buffers Signed-off-by: William Lew <[email protected]> * Updated example to show different types of uniforms Signed-off-by: William Lew <[email protected]> * Apply suggestions from code review Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: William Lew <[email protected]> * Apply style suggestions Signed-off-by: William Lew <[email protected]> * Removed support for engines other than OGRE1 Signed-off-by: William Lew <[email protected]> * Changed "WordBuffer" to "Buffer" Signed-off-by: William Lew <[email protected]> * Removed raw pointer when getting buffer Signed-off-by: William Lew <[email protected]> * Added windows support Signed-off-by: William Lew <[email protected]> * Fixed code check formatting issues Signed-off-by: William Lew <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the following examples to use a command line argument to determine which version of Ogre to use (Ogre1 vs. Ogre2):