Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence noisy sky error #282

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Silence noisy sky error #282

merged 1 commit into from
Apr 1, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

This was brought up during the tutorial party. This warning is always printed when using ogre1, even when the user is not trying to enable the sky. This change makes it so the error is only printed for users trying to enable sky.

Keeping this as draft until the stable release, it's not a critical bugfix.

CC @ammaar8

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #282 (0668a02) into main (e0bf818) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   57.54%   57.53%   -0.02%     
==========================================
  Files         159      159              
  Lines       15590    15591       +1     
==========================================
- Hits         8971     8970       -1     
- Misses       6619     6621       +2     
Impacted Files Coverage Δ
src/base/BaseScene.cc 74.95% <0.00%> (-0.13%) ⬇️
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 96.66% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0bf818...0668a02. Read the comment docs.

@chapulina chapulina changed the base branch from main to ign-rendering5 April 1, 2021 20:38
@chapulina chapulina marked this pull request as ready for review April 1, 2021 20:38
@chapulina chapulina merged commit 0c96fe8 into ign-rendering5 Apr 1, 2021
@chapulina chapulina deleted the chapulina/5/sky_error branch April 1, 2021 20:38
iche033 pushed a commit that referenced this pull request Apr 27, 2021
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants