Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment map tutorial #295

Merged
merged 4 commits into from
Apr 1, 2021
Merged

Add environment map tutorial #295

merged 4 commits into from
Apr 1, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 31, 2021

🎉 New feature

Summary

Add a new tutorial to show how to set an environment map to a mesh and also how to create a the environment map / cube map texture in gimp

Test it

Build ign-rendering and the open the doxygen index page: build/ignition-rendering5/doxygen/html/index.html

Go to Tutorials and you should see the new Environment map tutorial entry.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

iche033 added 2 commits March 31, 2021 12:16
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #295 (939fd4d) into main (8c21e50) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   57.54%   57.54%           
=======================================
  Files         159      159           
  Lines       15590    15590           
=======================================
  Hits         8971     8971           
  Misses       6619     6619           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c21e50...939fd4d. Read the comment docs.

Signed-off-by: Ian Chen <[email protected]>
@chapulina chapulina added the documentation Improvements or additions to documentation label Mar 31, 2021
tutorials/22_environment_map.md Show resolved Hide resolved
tutorials/22_environment_map.md Show resolved Hide resolved
@iche033 iche033 merged commit bfa4664 into main Apr 1, 2021
@iche033 iche033 deleted the envmap_tutorial branch April 1, 2021 18:21
iche033 added a commit that referenced this pull request Apr 27, 2021
* add envmap tutorial

Signed-off-by: Ian Chen <[email protected]>

* remove return

Signed-off-by: Ian Chen <[email protected]>

* tweaks

Signed-off-by: Ian Chen <[email protected]>

* remove lines, minor tweaks

Signed-off-by: Ian Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants