Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tools/code_check and update codecov #321

Merged
merged 2 commits into from
May 15, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina requested a review from iche033 as a code owner May 12, 2021 22:19
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #321 (4ddc439) into ign-rendering3 (0a54d81) will increase coverage by 2.55%.
The diff coverage is 62.42%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering3     #321      +/-   ##
==================================================
+ Coverage           50.39%   52.94%   +2.55%     
==================================================
  Files                 129      129              
  Lines               11692    11917     +225     
==================================================
+ Hits                 5892     6310     +418     
+ Misses               5800     5607     -193     
Impacted Files Coverage Δ
include/ignition/rendering/RayQuery.hh 100.00% <ø> (ø)
include/ignition/rendering/RenderPassSystem.hh 100.00% <ø> (ø)
include/ignition/rendering/base/BaseCamera.hh 70.27% <ø> (ø)
include/ignition/rendering/base/BaseDepthCamera.hh 16.66% <ø> (ø)
include/ignition/rendering/base/BaseMarker.hh 43.24% <ø> (ø)
include/ignition/rendering/base/BaseScene.hh 0.00% <ø> (ø)
...clude/ignition/rendering/base/BaseThermalCamera.hh 94.44% <ø> (ø)
...nclude/ignition/rendering/ogre/OgreRenderEngine.hh 100.00% <ø> (ø)
ogre/src/OgreDepthCamera.cc 0.00% <0.00%> (ø)
ogre/src/OgreGpuRays.cc 0.00% <0.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55a35a7...4ddc439. Read the comment docs.

@iche033 iche033 enabled auto-merge (squash) May 15, 2021 01:01
@iche033 iche033 merged commit d3eb5ca into ign-rendering3 May 15, 2021
@iche033 iche033 deleted the chapulina/codecheck branch May 15, 2021 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants