Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Mesh Tutorial. #352

Closed

Conversation

francocipollone
Copy link

@francocipollone francocipollone commented Jun 25, 2021

Signed-off-by: Franco Cipollone [email protected]

🎉 New feature

Summary

The mesh tutorial here created is migrated from Google Doc to an actual tutorial in ign-rendering
Tutorial Author: @RafiAbdullah

Some pics:
image

image

Test it

I share here the generated HTML in case you want to take a look:

tutorial_model_and_optimize_meshes.zip

After extracting the files you can use your favorite browser by doing: (e.g. using google chrome)

google-chrome model_and_optimize_meshes.html

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@francocipollone francocipollone requested a review from iche033 as a code owner June 25, 2021 18:30
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jun 25, 2021
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #352 (52f5ca3) into ign-rendering3 (5164539) will not change coverage.
The diff coverage is n/a.

❗ Current head 52f5ca3 differs from pull request most recent head cbbff1e. Consider uploading reports for the commit cbbff1e to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering3     #352   +/-   ##
===============================================
  Coverage           53.23%   53.23%           
===============================================
  Files                 131      131           
  Lines               12007    12007           
===============================================
  Hits                 6392     6392           
  Misses               5615     5615           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5164539...cbbff1e. Read the comment docs.

@chapulina chapulina added the documentation Improvements or additions to documentation label Jun 25, 2021
Signed-off-by: Franco Cipollone <[email protected]>

Co-authored-by: RafiAbdullah <[email protected]>
@francocipollone francocipollone force-pushed the francocipollone/add_mesh_tutorial branch from faafa71 to cbbff1e Compare June 25, 2021 19:11
@chapulina
Copy link
Contributor

Thank you for the tutorial, @francocipollone ! I don't remember if I was the one who suggested putting it in ign-rendering, but looking at it now, since it touches simulation concepts like collision, I think the tutorial should be in ign-gazebo instead. What do you think?

@francocipollone
Copy link
Author

francocipollone commented Jul 12, 2021

Thank you for the tutorial, @francocipollone ! I don't remember if I was the one who suggested putting it in ign-rendering, but looking at it now, since it touches simulation concepts like collision, I think the tutorial should be in ign-gazebo instead. What do you think?

Yeah I asked you about it on Slack. 😄 . It is true it mentions some simulation concepts, I could close it and replicate it in ign-gazebo then

@chapulina
Copy link
Contributor

Yeah I asked you about it on Slack. smile

Ha I thought so 🙈

I could close it and replicate it in ign-gazebo then

Thanks! I must have not realized earlier that it touched simulation-specific concepts 🙇‍♀️

@francocipollone
Copy link
Author

Closed in favor of gazebosim/gz-sim#915

@francocipollone francocipollone deleted the francocipollone/add_mesh_tutorial branch July 13, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants