Fix ogre 1.x tests #409
Merged
Fix ogre 1.x tests #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
|
homebrew build is now ✔️ |
Codecov Report
@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 58.53% 58.53%
=======================================
Files 174 174
Lines 17345 17346 +1
=======================================
+ Hits 10153 10154 +1
Misses 7192 7192
Continue to review full report at Codecov.
|
chapulina
added
beta
chapulina
approved these changes
Sep 16, 2021
| Ogre::MaterialManager::getSingleton().remove( | ||
| this->ogreSubEntity->getMaterialName()); | ||
| // this causes several tests to crash on exit because MaterialManager | ||
| // is already deleted before this call |
There was a problem hiding this comment.
Is this only a problem on macOS?
There was a problem hiding this comment.
it's a problem on ubuntu as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
Summary
homebrew builds are now running ogre 1.x tests in ign-rendering6, and there are currently a few test failures.
This PR fixes the failing tests.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge