Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 4.9.0 release #410

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Prepare for 4.9.0 release #410

merged 2 commits into from
Sep 16, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 15, 2021

Signed-off-by: Ian Chen [email protected]

🎈 Release

Preparation for 4.9.0 release.

Comparison to 4.8.0: ignition-rendering4_4.8.0...bump_4.9.0

Needed by <PR(s)>

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #410 (ea07f14) into ign-rendering4 (038317d) will not change coverage.
The diff coverage is n/a.

❗ Current head ea07f14 differs from pull request most recent head 4a0f1dc. Consider uploading reports for the commit 4a0f1dc to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering4     #410   +/-   ##
===============================================
  Coverage           56.32%   56.32%           
===============================================
  Files                 147      147           
  Lines               14119    14119           
===============================================
  Hits                 7952     7952           
  Misses               6167     6167           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038317d...4a0f1dc. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing some changelog entries that came in the 3-> 4 ports:

ignition-rendering4_4.8.0...ign-rendering4

Otherwise, LGTM.

Signed-off-by: Ian Chen <[email protected]>
@iche033
Copy link
Contributor Author

iche033 commented Sep 15, 2021

updated changelog in 4a0f1dc

@iche033 iche033 merged commit 29876ec into ign-rendering4 Sep 16, 2021
@iche033 iche033 deleted the bump_4.9.0 branch September 16, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants