Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address remaining Ogre2 heightmap comments #416

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 20, 2021

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

addressed remaining style changes mentioned in #386 and added a point light to the heightmap demo to showcase support for shadows in ogre2.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 20, 2021
@iche033 iche033 requested a review from ahcorde September 20, 2021 21:26
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #416 (71f7fa5) into main (56b30dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   55.05%   55.06%           
=======================================
  Files         191      191           
  Lines       19265    19265           
=======================================
+ Hits        10607    10608    +1     
+ Misses       8658     8657    -1     
Impacted Files Coverage Δ
ogre2/src/Ogre2Scene.cc 76.69% <ø> (ø)
ogre2/src/Ogre2RenderEngine.cc 79.80% <100.00%> (ø)
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b30dc...71f7fa5. Read the comment docs.

@chapulina chapulina added beta Targeting beta release of upcoming collection bug Something isn't working labels Sep 21, 2021
@iche033 iche033 merged commit 8e7c876 into main Sep 21, 2021
@iche033 iche033 deleted the ogre2_heightmap_style branch September 21, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants