Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Installation instruction to install ogre 2.2 #426

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 24, 2021

🦟 Bug fix

Summary

Update installation instruciton. Ign-rendering6 now depends on ogre 2.2

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 24, 2021
@chapulina chapulina added beta Targeting beta release of upcoming collection documentation Improvements or additions to documentation labels Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #426 (4cf981b) into main (d2ff058) will not change coverage.
The diff coverage is n/a.

❗ Current head 4cf981b differs from pull request most recent head 3c33880. Consider uploading reports for the commit 3c33880 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   55.12%   55.12%           
=======================================
  Files         192      192           
  Lines       19381    19381           
=======================================
  Hits        10683    10683           
  Misses       8698     8698           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ff058...3c33880. Read the comment docs.

@chapulina chapulina merged commit 45a49f0 into main Sep 24, 2021
@chapulina chapulina deleted the install_tweaks branch September 24, 2021 20:14
WilliamLewww pushed a commit to WilliamLewww/ign-rendering that referenced this pull request Dec 7, 2021
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: William Lew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection documentation Improvements or additions to documentation 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants