Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particles demo - run with ogre2 render engine by default #430

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 24, 2021

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

particles not supported in ogre1.x yet so run in ogre2 by default.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #430 (c737441) into ign-rendering6 (c9e76e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-rendering6     #430   +/-   ##
===============================================
  Coverage           53.49%   53.49%           
===============================================
  Files                 192      192           
  Lines               19560    19560           
===============================================
  Hits                10464    10464           
  Misses               9096     9096           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9e76e9...c737441. Read the comment docs.

@iche033 iche033 changed the base branch from main to ign-rendering6 October 7, 2021 06:20
@iche033 iche033 enabled auto-merge (squash) October 7, 2021 06:20
@iche033 iche033 disabled auto-merge October 7, 2021 07:16
@iche033 iche033 merged commit 50e1e5f into ign-rendering6 Oct 7, 2021
@iche033 iche033 deleted the particles_demo_ogre2 branch October 7, 2021 07:16
srmainwaring pushed a commit to srmainwaring/gz-rendering that referenced this pull request Oct 21, 2021
WilliamLewww pushed a commit to WilliamLewww/ign-rendering that referenced this pull request Dec 7, 2021
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: William Lew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants