Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Testing selection buffer #450

Closed
wants to merge 19 commits into from
Closed

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 2, 2021

Debugging selection buffer on CI by enabling VisualAt tests.

Do not merge.

@iche033 iche033 marked this pull request as draft October 2, 2021 05:30
@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #450 (6b0088e) into main (a8ac08c) will increase coverage by 1.77%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   53.49%   55.27%   +1.77%     
==========================================
  Files         192      192              
  Lines       19566    19577      +11     
==========================================
+ Hits        10467    10821     +354     
+ Misses       9099     8756     -343     
Impacted Files Coverage Δ
ogre2/src/Ogre2Camera.cc 88.31% <ø> (+14.89%) ⬆️
ogre2/src/Ogre2SelectionBuffer.cc 93.11% <82.14%> (+93.11%) ⬆️
ogre2/src/Ogre2RayQuery.cc 61.38% <100.00%> (+21.99%) ⬆️
src/Utils.cc 76.84% <0.00%> (+1.05%) ⬆️
ogre2/src/Ogre2Scene.cc 76.80% <0.00%> (+2.46%) ⬆️
include/ignition/rendering/RayQuery.hh 100.00% <0.00%> (+40.00%) ⬆️
ogre2/src/Ogre2MaterialSwitcher.cc 90.00% <0.00%> (+90.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ac08c...6b0088e. Read the comment docs.

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 changed the base branch from main to ign-rendering6 October 19, 2021 23:12
@iche033 iche033 changed the base branch from ign-rendering6 to main October 19, 2021 23:22
@iche033
Copy link
Contributor Author

iche033 commented Nov 2, 2021

changes in this branch has been merged into fix_selection_resize branch

@iche033 iche033 closed this Nov 2, 2021
@iche033 iche033 deleted the fix_selection_resize2 branch March 7, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant