Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
Partial fix for #499
Summary
When porting to ogre 2.2, lightmap and emissive map share the same texture slot. The fix adds a check to make sure we don't accidentally clear the emissive map when clearing out the lightmap texture.
There is still an issue of using grayscale emissive maps, in ogre2.2 it's being treated as RGB and so it's rendered red. This needs to be fixed next.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge