Fix Ogre2ThermalCamera using garbage depth data #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The depth buffer is created but never filled with anything. As a result it contains uninitialized values (likely 0.0f but it's not guaranteed) Signed-off-by: Matias N. Goldberg <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #523 +/- ##
===============================================
Coverage 54.44% 54.44%
===============================================
Files 198 198
Lines 20108 20107 -1
===============================================
Hits 10948 10948
+ Misses 9160 9159 -1
Continue to review full report at Codecov.
|
7 tasks
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The depth buffer is created but never filled with anything.
As a result it contains uninitialized values (likely 0.0f but it's not
guaranteed)
This bug seems to have been introduced when ported to Ogre 2.2
Signed-off-by: Matias N. Goldberg [email protected]
🦟 Bug fix
No ticket created for this
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.