Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable thermal camera tests on MacOS #659

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

Blast545
Copy link
Contributor

Signed-off-by: Jorge Perez [email protected]

Temporary remedy for #654

Summary

Tests known to fail on MacOS will not be run to help getting CI to a known state.

Checklist

  • Signed all commits for DCO
  • Added tests -> temprarily disabling tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@Blast545 Blast545 requested a review from iche033 as a code owner June 30, 2022 21:59
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 30, 2022
@Blast545 Blast545 self-assigned this Jun 30, 2022
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #659 (62fce79) into ign-rendering6 (2adcb97) will not change coverage.
The diff coverage is n/a.

❗ Current head 62fce79 differs from pull request most recent head baac721. Consider uploading reports for the commit baac721 to get more accurate results

@@               Coverage Diff               @@
##           ign-rendering6     #659   +/-   ##
===============================================
  Coverage           54.93%   54.93%           
===============================================
  Files                 202      202           
  Lines               21102    21102           
===============================================
  Hits                11592    11592           
  Misses               9510     9510           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adcb97...baac721. Read the comment docs.

@Blast545 Blast545 requested a review from chapulina July 1, 2022 13:59
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@Blast545
Copy link
Contributor Author

Blast545 commented Jul 4, 2022

All required checks passed + review, merging.

@Blast545 Blast545 merged commit 2261309 into ign-rendering6 Jul 4, 2022
@Blast545 Blast545 deleted the blast545/disable_fortress_654 branch July 4, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants