Combination of #685 and #694 #681
Conversation
mjcarroll
changed the title
Codecov Report
@@ Coverage Diff @@
## matias-ogre2.3 #681 +/- ##
===================================================
+ Coverage 53.18% 69.69% +16.50%
===================================================
Files 214 214
Lines 21550 21550
===================================================
+ Hits 11462 15019 +3557
+ Misses 10088 6531 -3557
Continue to review full report at Codecov.
|
|
@osrf-jenkins run tests please |
|
homebrew build doesn't seem to find ogre2:
|
|
the Ubuntu actions CI seems to find Ogre 2.3 properly but the jenkins Ubuntu build didn't: https://build.osrfoundation.org/job/ignition_rendering-ci-pr_any-ubuntu_auto-amd64/2524/ |
never mind, this is expected because Jenkins isn't using the |
|
@osrf-jenkins run tests please |
1 similar comment
|
@osrf-jenkins run tests please |
|
@osrf-jenkins retest this please |
|
@osrf-jenkins retest this please Edit: I rolled new cmake nightlies. |
|
let's try enabling the tests for ogre2 by removing the APPLE-specific logic here: |
I also dropped optix, which is unsupported everywhere afaict: |
mjcarroll
force-pushed
the
matias-ogre2.3
branch
from
6471798 to
72b59de
Compare
mjcarroll
force-pushed
the
ci_matching_branch/ogre23
branch
from
6a65c42 to
7a6931c
Compare
I still see a bunch of test failures with the following error:
|
I managed to grab an cc @iche033 |
|
an excerpt: |
|
OK I thought it was something else but this error is a big "WHAT?".
That error is key. It tells me that the OpenGL implementation doesn't provide However that sounds incredibly strange because any ancient OpenGL implementation would have Is anyone able to run Perhaps is this running inside VMWare? |
This isn't CI, but a local machine that I can reproduce on: https://gist.github.com/mjcarroll/fa27af5c4d6dfe8f226af48f8930bc3a
Negative, this is on the hardware |
|
Note that these tests have not been on in quite some time. Interestingly, even the examples (such as ogre2_demo) that were previously working no longer are. ogre2_demo log: https://gist.github.com/mjcarroll/604cadb2355127a64519ccad16180e0d |
yes, until b183065 in this branch, all tests were run with ogre1.9 on macOS. Now they are running with ogre2.3 |
|
That doesn't meet the minimum requirement of OpenGL 3.3+ However |
it may be an issue with Xquartz, which is being used by our CI machines: |
|
OK I just pushed a fix on Ogre 2.3 to fix this particular issue. However from what I can see this would've happened with OgreNext 2.2 too. The real problem is that the machine being used has ancient drivers, or wrong ones (it's weird because the UHD 630 is recent enough to never have such an old driver). Perhaps AH! If this is Ubuntu 18.04; perhaps the driver that is bundled with default Ubuntu is too old as Ubuntu 18.04 came a few months after UHD 630 You may need HWE:
Which contains newer drivers. If that doesn't do it, then a PPA like Kisak's may do the trick (which contains VERY recent drivers). Update: |
|
just catching up on the test failures. Looks like they are on homebrew on macOS. In that case, we should try running the tests with metal backend instead of opengl 3+. For example, this was done in the examples: Setting the param: This was also done in the PR for turning on metal in gazebo on macOS: |
As we have increased our number of potential configurations, we needed a bit of a refactor to be able to test all of the configurations. This changes the tests to no longer use gtest's parameterization, but rather use ctest's Signed-off-by: Michael Carroll <[email protected]>
* Port remaining tests to common framework Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
ci_matching_branch/ogre23
branch
from
0225827 to
c3b5daf
Compare
mjcarroll
changed the title
Signed-off-by: Michael Carroll [email protected]