Fixed CMakeLists.txt in examples #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
mjcarroll
reviewed
Jul 26, 2022
| find_package(ignition-rendering6 REQUIRED) | ||
| find_package(ignition-common4) |
There was a problem hiding this comment.
Should this be marked REQUIRED as well everywhere?
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #686 +/- ##
==================================================
- Coverage 54.58% 54.58% -0.01%
==================================================
Files 202 202
Lines 21106 21106
==================================================
- Hits 11521 11520 -1
- Misses 9585 9586 +1
Continue to review full report at Codecov.
|
mjcarroll
reviewed
Jul 26, 2022
| find_package(ignition-rendering6 REQUIRED) | ||
| find_package(ignition-find_package(ignition-common4 REQUIRED) |
There was a problem hiding this comment.
This doesn't look right. Find and replace gone wrong?
Signed-off-by: ahcorde <[email protected]>
mjcarroll
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde [email protected]
🦟 Bug fix
Related PR #678 and this comment #678 (comment)
Summary
Fixed CMakeLists.txt in examples. Include
ign-common4Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.