Fix wrong Z check in OgreWideAngleCamera::Project3d #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The matrix returned by Ogre::Camera::getProjectionMatrix has Z in range [-1; 1], not range [0; 1] This means we can't do pos.z > 0. We must do pos.z / pos.w > -1 Additionally, we must check against against z < 1; otherwise the point may get picked by the wrong face (and fail tests). Signed-off-by: Matias N. Goldberg <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #746 +/- ##
=======================================
Coverage 74.07% 74.07%
=======================================
Files 159 159
Lines 14408 14408
=======================================
Hits 10673 10673
Misses 3735 3735 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahcorde
approved these changes
Oct 24, 2022
|
I turned this PR into a draft because I discovered a better solution, as the current one has an undesired behavior I discovered while dealing with lens flare. |
This plays better with the far plane, while still playing fair with the near plane. Signed-off-by: Matias N. Goldberg <[email protected]>
|
OK I fixed the issue. It's ready now for review and merge |
|
New failure in Windows is unrelated to this changeset. |
mjcarroll
approved these changes
Oct 30, 2022
|
@sanjuksha @scpeters, you may be interested in this change for gazebo-classic |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
There is no ticket assigned to this bug
Summary
The matrix returned by Ogre::Camera::getProjectionMatrix has Z in range [-1; 1], not range [0; 1]
This means we can't do pos.z > 0. We must do pos.z / pos.w > -1 Additionally, we must check against against z < 1; otherwise the point may get picked by the wrong face (and fail tests).
I found this bug while porting OgreWideAngleCamera to ogre2
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.