Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bounding box for glbs #769

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Fix bounding box for glbs #769

merged 2 commits into from
Nov 29, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Nov 29, 2022

Signed-off-by: Alejandro Hernández Cordero [email protected]

🦟 Bug fix

Fixes gazebosim/gz-sim#1820

Summary

When loading glbs with ASSIMP are considered meshes with skeleton, this PR add one more check to know if the skeleton has animations, if it has animations then the bouding box it's (-1, -1, -1)(1, 1, 1) otherwise it's the maximum and minimum element of the mesh.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #769 (9c8a220) into gz-rendering7 (04b0f03) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           gz-rendering7     #769   +/-   ##
==============================================
  Coverage          75.47%   75.48%           
==============================================
  Files                164      164           
  Lines              14363    14364    +1     
==============================================
+ Hits               10841    10843    +2     
+ Misses              3522     3521    -1     
Impacted Files Coverage Δ
ogre2/src/Ogre2MeshFactory.cc 80.80% <100.00%> (+0.06%) ⬆️
include/gz/rendering/base/BaseGaussianNoisePass.hh 100.00% <0.00%> (+3.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde enabled auto-merge (squash) November 29, 2022 18:33
@ahcorde ahcorde merged commit cc8a9ff into gz-rendering7 Nov 29, 2022
@ahcorde ahcorde deleted the ahcorde/7/bounding_box branch November 29, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Wrong bounding box with glb meshes loaded with Assimp
3 participants