Fix RenderTarget::destroy not getting called in both ogre1 & ogre2 #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #776 +/- ##
==================================================
+ Coverage 77.82% 77.85% +0.03%
==================================================
Files 146 146
Lines 13399 13404 +5
==================================================
+ Hits 10428 10436 +8
+ Misses 2971 2968 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Matias N. Goldberg <[email protected]>
darksylinc
force-pushed
the
matias-renderTargetDestroy
branch
from
a8d2097 to
67012b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matias N. Goldberg [email protected]
🦟 Bug fix
No ticket was filed for this bug.
Summary
During PR #775 I discovered this bug.
That PR will fix that bug in main, this is a backport for Fortress.
A tiny difference is that in
mainchanges were done so that RenderPasses are destroyed cleanly, while in Fortress' backport I can't do that without breaking the ABI.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.