Enable ray heightmap ray query #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-rendering7 #778 +/- ##
=================================================
+ Coverage 75.53% 76.12% +0.58%
=================================================
Files 164 164
Lines 14382 14392 +10
=================================================
+ Hits 10864 10956 +92
+ Misses 3518 3436 -82
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahcorde
requested changes
Dec 6, 2022
Signed-off-by: Ian Chen <[email protected]>
ahcorde
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
Summary
Ray queries now return intersection points with heightmaps. This fixes the issue with weird view control movements when orbiting / panning with a mouse on heightmaps. However, mouse picking (selecting heightmap visual) is not working yet. It may require a change to API - added a todo for this.
To test
Run the
Utils_TEST:Camera movement in
heightmapdemo should also be working well now. Build and run the demo. Move camera with the mouse and you should see the anchor points for camera orbiting and panning should now be where the mouse click is.You can also try view control in
heightmaps.dfworld in gz sim.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.