Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
Summary
Make sure vulkan exists before building ogre2. This is needed by Jammy after #706 introduced the
vulkan/vulkan_core.h
include header. Otherwise build fails.We should only just need the vulkan headers and not the whole library.
Alternative solution is to manually search forvulkan_core.h
usingFIND_PATH
in cmake. I went withgz_find_package
for simplicity as the headers are installed with the library when you doapt install libvulkan-dev
find_path
to look for vulkan headers and adding more logic to make sure ogre-next is built with vulkan supportNote that the
libvulkan-dev
dependency has already been added to packages-jammy.apt and our Jammy debbuild CI script.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.