Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Metal shader compiler error in GpuRays (Lidar) #786

Merged

Conversation

darksylinc
Copy link
Contributor

Signed-off-by: Matias N. Goldberg [email protected]

🦟 Bug fix

No ticket filed for this bug report.

Summary

Trying to use the heightmap in GpuRays (Lidar) in macOS / Metal will result in a shader compiler error.

This is a backport from PR #785 which includes this fix alongside the integration test that discovered this bug.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@darksylinc darksylinc requested a review from iche033 as a code owner December 11, 2022 16:11
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Dec 11, 2022
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #786 (be8a7ea) into ign-rendering6 (a056220) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-rendering6     #786   +/-   ##
===============================================
  Coverage           77.85%   77.85%           
===============================================
  Files                 146      146           
  Lines               13404    13404           
===============================================
  Hits                10436    10436           
  Misses               2968     2968           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit b3df123 into gazebosim:ign-rendering6 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants