Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory corruption in Ogre2GpuRays (Garden) #788

Merged

Conversation

darksylinc
Copy link
Contributor

🦟 Bug fix

No ticket was filed for this bug.

Summary

Same as PR #787

Garden flavour.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Order of destruction was inverted

Signed-off-by: Matias N. Goldberg <[email protected]>
Signed-off-by: Matias N. Goldberg <[email protected]>
@darksylinc darksylinc requested a review from iche033 as a code owner December 11, 2022 21:22
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 11, 2022
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #788 (0b05a60) into gz-rendering7 (918c1f1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           gz-rendering7     #788      +/-   ##
=================================================
- Coverage          76.12%   76.12%   -0.01%     
=================================================
  Files                164      164              
  Lines              14392    14390       -2     
=================================================
- Hits               10956    10954       -2     
  Misses              3436     3436              
Impacted Files Coverage Δ
ogre2/src/Ogre2GpuRays.cc 91.42% <100.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit d07c0c6 into gazebosim:gz-rendering7 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants