Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More ign to gz changes #795

Merged
merged 2 commits into from
Dec 22, 2022
Merged

More ign to gz changes #795

merged 2 commits into from
Dec 22, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Dec 21, 2022

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

these got introduced likely from forward ports.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 21, 2022
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #795 (bd42688) into gz-rendering7 (6968855) will not change coverage.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           gz-rendering7     #795   +/-   ##
==============================================
  Coverage          76.10%   76.10%           
==============================================
  Files                164      164           
  Lines              14393    14393           
==============================================
  Hits               10954    10954           
  Misses              3439     3439           
Impacted Files Coverage Δ
ogre2/src/Ogre2RayQuery.cc 62.18% <0.00%> (ø)
src/OrbitViewController.cc 67.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit bf15100 into gz-rendering7 Dec 22, 2022
@ahcorde ahcorde deleted the more_ign_to_gz branch December 22, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants