Mesh cleanup on destruction #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-rendering6 #807 +/- ##
===============================================
Coverage 77.83% 77.83%
===============================================
Files 146 146
Lines 13416 13417 +1
===============================================
+ Hits 10442 10443 +1
Misses 2974 2974
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Will and new release of rendering6 be created with this patch by chance? |
|
Github is saying |
|
targeted wrong branch. Just updated. |
|
we can do a patch / minor release afterwards. |
ahcorde
approved these changes
Jan 19, 2023
|
just made an ign-rendering 6.5.2 patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
Fixes #805
Summary
The code snippet in #805 identified a case in which a mesh is not properly destroyed when it goes out of scope, see code and comment below
ignition::rendering::MeshPtr mesh_geom = scene.CreateMesh(descriptor); // the line below leaves the original `mesh_geom` dangling and we are not cleaning it up properly mesh_geom = scene.CreateMesh(descriptor);This PR makes sure the
Destroyfunction is called in the mesh destructor.The mesh unit test is updated to cover the use case shown in #805
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.