Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requiring OpenGL on macOS. #844

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix requiring OpenGL on macOS. #844

merged 1 commit into from
Apr 25, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Apr 24, 2023

🦟 Bug fix

Related: osrf/homebrew-simulation#2237 (comment)

Summary

#840 explicitly made OpenGL a required component but that broke pkg-config in homebrew. This PR reverts the change for macOS.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from scpeters April 24, 2023 19:55
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #844 (9101bbb) into gz-rendering7 (80d41b2) will not change coverage.
The diff coverage is n/a.

❗ Current head 9101bbb differs from pull request most recent head 4bd723e. Consider uploading reports for the commit 4bd723e to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering7     #844   +/-   ##
==============================================
  Coverage          77.37%   77.37%           
==============================================
  Files                164      164           
  Lines              14459    14459           
==============================================
  Hits               11187    11187           
  Misses              3272     3272           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033 iche033 merged commit 7091c94 into gz-rendering7 Apr 25, 2023
@iche033 iche033 deleted the fix_pkgconfig_mac branch April 25, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants