Fix a leak in ogre2 ray query

[shameekganguly]

No description provided.

[codecov]

Codecov Report

Merging #866 (8e58cf7) into gz-rendering7 (537bcea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8e58cf7 differs from pull request most recent head add464d. Consider uploading reports for the commit add464d to get more accurate results

@@              Coverage Diff               @@
##           gz-rendering7     #866   +/-   ##
==============================================
  Coverage          77.14%   77.14%           
==============================================
  Files                170      170           
  Lines              14715    14720    +5     
==============================================
+ Hits               11352    11356    +4     
- Misses              3363     3364    +1     

Impacted Files	Coverage Δ
ogre2/src/Ogre2RayQuery.cc	63.41% <100.00%> (+1.55%)	⬆️

... and 1 file with indirect coverage changes

[iche033]

how about putting this in the Ogre2RayQuery destructor? and use ogre's scene manager to destroy the query object:

diff --git a/ogre2/src/Ogre2RayQuery.cc b/ogre2/src/Ogre2RayQuery.cc
index 8d7684c9..8a9826c3 100644
--- a/ogre2/src/Ogre2RayQuery.cc
+++ b/ogre2/src/Ogre2RayQuery.cc
@@ -71,6 +71,16 @@ Ogre2RayQuery::Ogre2RayQuery()
 //////////////////////////////////////////////////
 Ogre2RayQuery::~Ogre2RayQuery()
 {
+  if (this->dataPtr->rayQuery)
+  {
+    Ogre2ScenePtr ogreScene =
+        std::dynamic_pointer_cast<Ogre2Scene>(this->Scene());
+    if (ogreScene)
+    {
+      ogreScene->OgreSceneManager()->destroyQuery(this->dataPtr->rayQuery);
+      this->dataPtr->rayQuery = nullptr;
+    }
+  }
 }

[shameekganguly]

Thanks Ian, updated the PR with your suggestion.