Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Focal on Harmonic #868

Merged
merged 2 commits into from
Jul 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,17 @@ name: Ubuntu CI
on: [push, pull_request]

jobs:
focal-ci:
jammy-ci:
runs-on: ubuntu-latest
name: Ubuntu Focal CI
name: Ubuntu Jammy CI
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Compile and test
id: ci
uses: gazebo-tooling/action-gz-ci@focal
uses: gazebo-tooling/action-gz-ci@jammy
with:
codecov-enabled: true
cppcheck-enabled: true
cpplint-enabled: true
doxygen-enabled: true
jammy-ci:
runs-on: ubuntu-latest
name: Ubuntu Jammy CI
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Compile and test
id: ci
uses: gazebo-tooling/action-gz-ci@jammy
2 changes: 1 addition & 1 deletion include/gz/rendering/Camera.hh
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ namespace gz
/// Setting a value <= 0.0 indicates the aspect ratio will be
/// automatically calculated based on width & height.
///
/// \return The camera's aspect ratio
/// \param[in] _ratio The camera's aspect ratio
public: virtual void SetAspectRatio(const double _ratio) = 0;

// TODO(anyone): add auto-aspect ratio
Expand Down
2 changes: 1 addition & 1 deletion include/gz/rendering/LidarVisual.hh
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ namespace gz
public: virtual unsigned int VerticalRayCount() const = 0;

/// \brief Set number of horizontal rays
/// \return _horizontalRayCount Number of vertical rays
/// \param[in] _horizontalRayCount Number of vertical rays
public: virtual void SetHorizontalRayCount(
unsigned int _horizontalRayCount) = 0;

Expand Down
1 change: 0 additions & 1 deletion include/gz/rendering/RenderEngine.hh
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ namespace gz
/// \brief Destroys all scenes created by render-engine and releases all
/// loaded resources. This should be called when the given render-engine
/// will no longer be used during runtime.
/// \return True if the render-engine was successfully destroyed
public: virtual void Destroy() = 0;

// TODO(anyone): merge with Destroy
Expand Down