Parse correctly OGRE2_RESOURCE_PATH on Windows #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
force-pushed
the
fixwinwrongpartition
branch
4 times, most recently
from
799ebd5 to
d9edf09
Compare
iche033
approved these changes
May 2, 2024
|
looks good to me. Can you fix DCO? |
Signed-off-by: Silvio Traversaro <[email protected]>
traversaro
force-pushed
the
fixwinwrongpartition
branch
from
118fdca to
07c28d3
Compare
Done! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gz-rendering7 #996 +/- ##
==============================================
Coverage 77.68% 77.68%
==============================================
Files 170 170
Lines 14733 14733
==============================================
Hits 11445 11445
Misses 3288 3288 ☔ View full report in Codecov by Sentry. |
mjcarroll
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes wrong handling of
OGRE2_RESOURCE_PATHon Windows.Summary
It was assume that the
OGRE2_RESOURCE_PATHwas a:-delimiter list of paths. However, on Windows:is the separator between the drive letter and the path, so;should be used instead.Everything was working fine as
C:\this\is\a\pathand\this\is\a\pathare both valid paths if the active drive isC:\, but as soon as the current active directory was for example onD:,OGRE2_RESOURCE_PATHwas not read correctly, see conda-forge/gz-sim-feedstock#57 .Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.