Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ‘ฉโ€๐ŸŒพ 4 โžก๏ธ 5 #123

Merged
merged 5 commits into from
Apr 23, 2021

Conversation

chapulina
Copy link
Contributor

โžก๏ธ Forward port

Port ign-sensors4 to ign-sensors5.

Branch comparison: ign-sensors5...ign-sensors4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ

https://github.com/osrf/buildfarmer/issues/181

@chapulina chapulina requested a review from iche033 as a code owner April 22, 2021 17:06
@chapulina chapulina changed the title 4 โžก๏ธ 5 ๐Ÿ‘ฉโ€๐ŸŒพ 4 โžก๏ธ 5 Apr 22, 2021
@github-actions github-actions bot added the ๐Ÿข edifice Ignition Edifice label Apr 22, 2021
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MacOS is sad, but not sure if it's a different sad.

@chapulina
Copy link
Contributor Author

It's a different sad, I'm focusing on Jenkins right now. Let me follow up on macOS actions on #80

scpeters and others added 2 commits April 22, 2021 16:57
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

macOS actions disabled on #124, which is included here.

I expect this to be all ๐ŸŸข

@chapulina
Copy link
Contributor Author

I expect this to be all ๐ŸŸข

Expectations met!

@chapulina chapulina merged commit 36e5308 into ign-sensors5 Apr 23, 2021
@chapulina chapulina deleted the chapulina/4_to_5 branch April 23, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿข edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants