Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init will now set the nextUpdateTime to zero #137

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jun 16, 2021

Signed-off-by: Nate Koenig [email protected]

🎉 New feature

Summary

I needed a way to reset the nextUpdateTime to zero when seeking backward in a log file. Modifying ::Init seemed convenient and unlikely to affect anyone. I can make a new function to accomplish the same goal if that is perferred.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me.

I needed a way to reset the nextUpdateTime to zero when seeking backward in a log file.

Note that using Init may have unintended consequences though. Right now it looks like no sensors are adding extra logic to Init, but they could eventually. Just something to keep in mind.

@nkoenig nkoenig merged commit a9ba28d into ign-sensors4 Jun 18, 2021
@nkoenig nkoenig deleted the init_reset_time branch June 18, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants