Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cpplint check in github actions CI #198

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Mar 1, 2022

🎉 New feature

Summary

Enable cpplint checking in GitHub actions CI

Test it

Look at results of GitHub actions CI jobs

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from iche033 as a code owner March 1, 2022 22:17
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #198 (0c3ba2c) into ign-sensors6 (940547a) will not change coverage.
The diff coverage is n/a.

❗ Current head 0c3ba2c differs from pull request most recent head d624b47. Consider uploading reports for the commit d624b47 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-sensors6     #198   +/-   ##
=============================================
  Coverage         76.55%   76.55%           
=============================================
  Files                29       29           
  Lines              2871     2871           
=============================================
  Hits               2198     2198           
  Misses              673      673           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940547a...d624b47. Read the comment docs.

@scpeters scpeters merged commit 0e1f36b into ign-sensors6 Mar 3, 2022
@scpeters scpeters deleted the scpeters/enable-cpplint branch March 3, 2022 00:29
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants