Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable thermal camera test on MacOS #243

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

Blast545
Copy link
Contributor

@Blast545 Blast545 commented Jul 4, 2022

Signed-off-by: Jorge Perez [email protected]

Summary

Disabling a faling test on MacOS, I think it's closely related to same error described here: gazebosim/gz-rendering#654. I think it's better to track both issues together, I can open a new issue if it's preferred for this test.

Should fix remaining test regression on MacOS + Fortress buildfarm jobs.
Reference, see: https://build.osrfoundation.org/job/ignition_sensors-ci-ign-sensors6-homebrew-amd64/25/
FYI: @Crola1702

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Blast545 Blast545 requested a review from iche033 as a code owner July 4, 2022 16:27
@Blast545 Blast545 self-assigned this Jul 4, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #243 (a931810) into ign-sensors6 (7f0fd50) will not change coverage.
The diff coverage is n/a.

❗ Current head a931810 differs from pull request most recent head ff88ae6. Consider uploading reports for the commit ff88ae6 to get more accurate results

@@              Coverage Diff              @@
##           ign-sensors6     #243   +/-   ##
=============================================
  Coverage         72.16%   72.16%           
=============================================
  Files                34       34           
  Lines              3470     3470           
=============================================
  Hits               2504     2504           
  Misses              966      966           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f0fd50...ff88ae6. Read the comment docs.

@chapulina chapulina added macOS macOS support tests Broken or missing tests / testing infra labels Jul 6, 2022
@Blast545
Copy link
Contributor Author

Blast545 commented Jul 6, 2022

There seems to be some other errors Jammy github actions CI that will be addressed separately.

Thanks for the reviews! Merging.

@Blast545 Blast545 merged commit 1521ad5 into ign-sensors6 Jul 6, 2022
@Blast545 Blast545 deleted the blast545/disable_thermal_camera_test branch July 6, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress macOS macOS support tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants