Add missing DEPENDS_ON_COMPONENTS parameters #262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes homebrew build of ign-gazebo3 osrf/homebrew-simulation#2008, alternative to gazebosim/gz-sim#1663
Summary
The ign-gazebo3 builds have been failing since ign-sensors 3.4.0 was released (see osrf/homebrew-simulation#2008 (comment)).
From the cmake output:
There are some component libraries that link to other component libraries but they also need to declare those dependencies with the
DEPENDS_ON_COMPONENTS
parameter toign_add_component
(see gz-physics/dartsim for example). This adds all the missingDEPENDS_ON_COMPONENTS
calls that I could see, and fixes theign-gazebo3
build in my local testing.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.